[haiku-commits] Change in haiku[master]: xhci: SubmitNormalRequest: divide exception on zero trbSize

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: waddlesplash <waddlesplash@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 8 Jan 2021 16:04:38 +0000

From Jérôme Duval <jerome.duval@xxxxxxxxx>:

Jérôme Duval has uploaded this change for review. ( 
https://review.haiku-os.org/c/haiku/+/3611 ;)


Change subject: xhci: SubmitNormalRequest: divide exception on zero trbSize
......................................................................

xhci: SubmitNormalRequest: divide exception on zero trbSize

workaround for #16586
---
M src/add-ons/kernel/busses/usb/xhci.cpp
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://git.haiku-os.org:22/haiku refs/changes/11/3611/1

diff --git a/src/add-ons/kernel/busses/usb/xhci.cpp 
b/src/add-ons/kernel/busses/usb/xhci.cpp
index ce841c4..2b8a16a 100644
--- a/src/add-ons/kernel/busses/usb/xhci.cpp
+++ b/src/add-ons/kernel/busses/usb/xhci.cpp
@@ -815,6 +815,9 @@
                        return B_BAD_VALUE;
        }

+       if (trbSize == 0)
+               return B_BAD_VALUE;
+
        // Now that we know trbSize, compute the count.
        const int32 trbCount = (transfer->DataLength() + trbSize - 1) / trbSize;


--
To view, visit https://review.haiku-os.org/c/haiku/+/3611
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-Change-Id: Id9d538f46b62585f4a12c3796781ae1207ed2454
Gerrit-Change-Number: 3611
Gerrit-PatchSet: 1
Gerrit-Owner: Jérôme Duval <jerome.duval@xxxxxxxxx>
Gerrit-MessageType: newchange

Other related posts:

  • » [haiku-commits] Change in haiku[master]: xhci: SubmitNormalRequest: divide exception on zero trbSize - Gerrit