From Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>:
Adrien Destugues has posted comments on this change. (
https://review.haiku-os.org/475 ;)
Change subject: Remove Curl, Switch to NetApi in Package Kit
......................................................................
Patch Set 4: Code-Review-1
(6 comments)
https://review.haiku-os.org/#/c/475/4/src/kits/package/FetchFileJob.cpp
File src/kits/package/FetchFileJob.cpp:
https://review.haiku-os.org/#/c/475/4/src/kits/package/FetchFileJob.cpp@91
PS4, Line 91: BUrlRequest* request =
BUrlProtocolRoster::MakeRequest(fFileURL.String(), this);
Line > 80 columns
https://review.haiku-os.org/#/c/475/4/src/kits/package/FetchFileJob.cpp@106
PS4, Line 106: const BHttpResult& outResult = dynamic_cast<const
BHttpResult&>(request->Result());
Line > 80 columns
https://review.haiku-os.org/#/c/475/4/src/kits/package/FetchFileJob.cpp@138
PS4, Line 138: FetchFileJob::DataReceived(BUrlRequest*, const char* data, off_t
position, ssize_t size)
Line > 80 columns
https://review.haiku-os.org/#/c/475/4/src/kits/package/FetchFileJob.cpp@145
PS4, Line 145: FetchFileJob::DownloadProgress(BUrlRequest*, ssize_t
bytesReceived, ssize_t bytesTotal)
Line > 80 columns
https://review.haiku-os.org/#/c/475/4/src/kits/package/FetchFileJob.cpp@213
PS4, Line 213: ssize_t
off_t was correct here. Otherwise, we get wrong results on 32bit system for a
file larger than 2GB.
https://review.haiku-os.org/#/c/475/4/src/kits/package/FetchFileJob.cpp@220
PS4, Line 220: ssize_t
Same here.
--
To view, visit https://review.haiku-os.org/475
To unsubscribe, or for help writing mail filters, visit
https://review.haiku-os.org/settings
Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I92213ab60dc987175c323d1d9ed11ac8b3517f2f
Gerrit-Change-Number: 475
Gerrit-PatchSet: 4
Gerrit-Owner: Jacob S <themysterymail555@xxxxxxxxx>
Gerrit-Reviewer: Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
Gerrit-Reviewer: Jacob S <themysterymail555@xxxxxxxxx>
Gerrit-Reviewer: waddlesplash <waddlesplash@xxxxxxxxx>
Gerrit-Comment-Date: Sat, 25 Aug 2018 06:44:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
