From Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>:
Adrien Destugues has posted comments on this change. (
https://review.haiku-os.org/476 ;)
Change subject: Support : Validation for Host Portion of URL
......................................................................
Patch Set 3:
(1 comment)
https://review.haiku-os.org/#/c/476/3/src/tests/kits/net/libnetapi/NetworkUrlTest.cpp
File src/tests/kits/net/libnetapi/NetworkUrlTest.cpp:
https://review.haiku-os.org/#/c/476/3/src/tests/kits/net/libnetapi/NetworkUrlTest.cpp@394
PS3, Line 394: // Invalid Host
----------------------------------------------------------------
A better wording would be "host validation" (we test both valid and invalid
cases)
And also it would be better to use a #pragma mark rather than -------- for our
friends still using Pe (and we should support something similar in other
editors).
Maybe this comment is not really useful since the test name should already be
clear enough, anyways?
--
To view, visit https://review.haiku-os.org/476
To unsubscribe, or for help writing mail filters, visit
https://review.haiku-os.org/settings
Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia611d3653d2c16c6dcdc48ce57bd61bb6e6db366
Gerrit-Change-Number: 476
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Lindesay <apl@xxxxxxxxxxxxxx>
Gerrit-Reviewer: Adrien Destugues <pulkomandy@xxxxxxxxxxxxx>
Gerrit-Reviewer: Andrew Lindesay <apl@xxxxxxxxxxxxxx>
Gerrit-Reviewer: Kacper Kasper <kacperkasper@xxxxxxxxx>
Gerrit-Comment-Date: Sat, 25 Aug 2018 06:47:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No