[haiku-commits] Change in haiku[master]: Media server: Suppress -Werror=class-memaccess

  • From: Gerrit <review@xxxxxxxxxxxxxxxxxxx>
  • To: Murai Takashi <tmurai01@xxxxxxxxx>, haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 25 Aug 2018 15:26:42 +0000

From Barrett17 <b.vitruvio@xxxxxxxxx>:

Barrett17 has posted comments on this change. ( https://review.haiku-os.org/485 ;
)

Change subject: Media server: Suppress -Werror=class-memaccess
......................................................................


Patch Set 1: Code-Review-2

Hi mt, I appreciate a lot your work on cleaning up those errors. However, when 
something is fixed I'd like it to be fixed properly.

Some of those memset are unneeded, as memsetting is already done in 
constructor, could you please review your patches and remove the memset instead 
of replacing it with Clear where it makes sense?


--
To view, visit https://review.haiku-os.org/485
To unsubscribe, or for help writing mail filters, visit 
https://review.haiku-os.org/settings

Gerrit-Project: haiku
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If905db6c0b7d759e72cfa649951be5109f952f54
Gerrit-Change-Number: 485
Gerrit-PatchSet: 1
Gerrit-Owner: Murai Takashi <tmurai01@xxxxxxxxx>
Gerrit-Reviewer: Barrett17 <b.vitruvio@xxxxxxxxx>
Gerrit-Comment-Date: Sat, 25 Aug 2018 15:26:42 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Other related posts: