[haiku-commits] Re: haiku: hrev52055 - src/kits/media headers/os/media
- From: Dario Casalinuovo <b.vitruvio@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sat, 25 Aug 2018 17:44:23 +0200
Good morning,
You have commit access. Just revert the commit, it would waste a lot
less time.
You can explain the reasons in the commit message and we can happily
move on and
rework and resubmit the patch.
Do you believe that reverting the commit abruptly looked like a much
more rude behavior for me?
Not if you take the time to explain your rationale in the commit message.
Demanding that someone
else reverts the commit for you is like "I don't have time to mess with
this, please someone less
important do it for me". Doing it yourself is showing that you can get
work done when needed.
Since it seems no one care about fixing at least two of the important
issues pointed out, I will be forced to revert the interested commits, as
the patches doesn't respect the code quality I am used to see in this
project.
Issues for which no fix patch has been submitted:
* Lots of memset calls are not needed and should be removed.
* The patch breaks metadata initialization/cleanup in media_format.
Either the reviewers or the committer doesn't seem interested into that.
Secondarily:
* It seems to me everyone agree Clear is not a good naming for this method
(if not please explain why) and should be instead called Unset following
the API style.
--
Saluti,
Dario
Other related posts:
