[haiku-commits] Re: BRANCH waddlesplash-github.tracker_cleanup_threads_properly [9749bc4c0ab9] src/kits/tracker

  • From: waddlesplash <waddlesplash@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 29 Apr 2017 19:46:49 -0400

On Sat, Apr 29, 2017 at 5:32 PM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
wrote:

Am 29/04/2017 um 22:30 schrieb waddlesplash-github.tracker_cl
eanup_threads_properly:

+       printf("exitOK\n");


Left over debug output.


Yes, this is in no state to be committed to master, so I didn't bother
cleaning up.



-                       if (!lock.Lock()) {
+                       if (!lock.LockWithTimeout(1000000)) {


Do you really have to do that? Can't you simply delete the lock instead?
That would be a good way to let lockers fail immediately.


Unless I really missed something, the lock is the looper lock for the
BPoseView, and this code will deadlock in the destructor unless there is a
mechanism for it to timeout. So, no, that's not an option.

-waddlesplash

Other related posts: