[haiku-bugs] Re: [Haiku] #8451: acpi_cpuidle: try to decode cstate from acpi _CST

  • From: "bonefish" <trac@xxxxxxxxxxxx>
  • Date: Sat, 07 Apr 2012 10:58:41 -0000

#8451: acpi_cpuidle: try to decode cstate from acpi _CST
   Reporter:  yongcong      |      Owner:  tqh
       Type:  enhancement   |     Status:  new
   Priority:  normal        |  Milestone:  R1
  Component:  Drivers/ACPI  |    Version:  R1/alpha3
 Resolution:                |   Keywords:  gsoc2012
 Blocked By:                |   Blocking:
Has a Patch:  1             |   Platform:  All

Comment (by bonefish):

 I'm not familiar with ACPI, so just a few general remarks:
  - In the Jamfile the `SetSubDirSupportedPlatformsBeOSCompatible`
 invocation and the `$(TARGET_PLATFORM) != haiku` block are superfluous. I
 don't think that anyone still develops this code on BeOS -- it probably
 doesn't even work there anymore.
  - Coding style: After the `//` leading a C++ comment there should be a
  - Preferred pointer style is `type* foo` instead of `type *foo`, though
 the code base is still rather mixed in this regard. New code should prefer
 the former, though.
  - Unless there's a good reason not to, make source files C++ files. Among
 other things this allows variable definitions to be moved to their
 initialization point and also results in better warnings.

Ticket URL: <http://dev.haiku-os.org/ticket/8451#comment:2>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: