[haiku-bugs] Re: [Haiku] #2970: Adamation personalStudio 1.5 trial don't work on Haiku 28283
- From: "modeenf" <trac@xxxxxxxxxxxx>
- Date: Mon, 30 May 2011 12:20:11 -0000
#2970: Adamation personalStudio 1.5 trial don't work on Haiku 28283
----------------------------+---------------------------
Reporter: miqlas | Owner: modeenf
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Applications | Version: R1/pre-alpha1
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 0 | Platform: x86
----------------------------+---------------------------
Comment (by modeenf):
Replying to [comment:5 stippi]:
> Good work on that patch. A few points:
>
> * Can you comment on why you don't need to call get_next_encoder() in a
loop in BMediaEncoder::SetTo(const media_format *output_format)? I don't
quite recall the semantics of that function right now.
No it needs to do the loop an then return the found encoder so this have
been changed
>
> * Some coding style violations: The opening bracket for functions
always goes on a separate line.
Fixed.
>
> * AttachToDecoder() is not checking fEncoder for being valid. Also,
shouldn't this be a private method?
Fixed
>
> Thanks a lot for working on this!
I have looked in to this but as you perhaps have seen I wanted to get my
network card to work :)
I have also done the same changes and checks in MediaDecoder following
BeBook
Do you want to have a diff to play with or should i commit? Also what have
we that one can test this?
--
Ticket URL: <http://dev.haiku-os.org/ticket/2970#comment:7>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
