[haiku-bugs] Re: [Haiku] #2970: Adamation personalStudio 1.5 trial don't work on Haiku 28283
- From: "stippi" <trac@xxxxxxxxxxxx>
- Date: Sat, 15 May 2010 12:13:54 -0000
#2970: Adamation personalStudio 1.5 trial don't work on Haiku 28283
--------------------------+-------------------------------------------------
Reporter: miqlas | Owner: modeenf
Type: bug | Status: new
Priority: normal | Milestone: R1
Component: Applications | Version: R1/pre-alpha1
Keywords: | Blockedby:
Platform: x86 | Blocking:
--------------------------+-------------------------------------------------
Comment(by stippi):
Good work on that patch. A few points:
* Can you comment on why you don't need to call get_next_encoder() in a
loop in BMediaEncoder::SetTo(const media_format *output_format)? I don't
quite recall the semantics of that function right now.
* Some coding style violations: The opening bracket for functions always
goes on a separate line.
* AttachToDecoder() is not checking fEncoder for being valid. Also,
shouldn't this be a private method?
Thanks a lot for working on this!
--
Ticket URL: <http://dev.haiku-os.org/ticket/2970#comment:5>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
