#12710: BPackageInfo; URL Validation Checks
--------------------------------+----------------------------
Reporter: apl-haiku | Owner: bonefish
Type: enhancement | Status: new
Priority: normal | Milestone: Unscheduled
Component: Kits/Package Kit | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
--------------------------------+----------------------------
Comment (by apl-haiku):
Hi Axel; Thanks for the clarification.
It seems then that the build with GCC 5.3.1 is working fine at my end. I
can build an image without any compilation failures and can then test the
change is working OK on the build host. I wonder what the difference
would be?
I am now taking a look at the other issues. The issue at
PackageInfoParser.cpp:1174 with the if statement;
* I have moved the logical or (`||`) operators to the start of the lines
* I cannot see an white-space issues there; can you please point out the
issue
I can see a 80 column limit violation at PackageInfoParser.h:165. I
checked the 'coding guidelines' page, but I cannot see any specific
guidance. Maybe something like the following would work?
{{{
...
struct BPackageInfo::Parser::UrlStringValidator :
public BPackageInfo::Parser::StringValidator {
...
}}}
I can also see one other 80 column violation at PackageInfoParser.cpp:1215
- no problem to fix. I am not sure where whitespace has been added. Are
you able to provide line number references for any white-space issues?
Also fixed a couple of situations where bad pointer references were used;
`char *f` instead of `char* f`.
--
Ticket URL: <https://dev.haiku-os.org/ticket/12710#comment:10>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
