#12710: BPackageInfo; URL Validation Checks
--------------------------------+----------------------------
Reporter: apl-haiku | Owner: bonefish
Type: enhancement | Status: new
Priority: normal | Milestone: Unscheduled
Component: Kits/Package Kit | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
--------------------------------+----------------------------
Comment (by axeld):
Thanks for the update, Andrew! I cannot comment about the host parsing
changes to BUrl, but the rest looks good. Personally, I wouldn't mind the
ReadMe.md in its current location.
I spotted a number of minor coding style issue, however (in Url.cpp):
* line 22, 27-28: we usually indent #if/include/define like this (I
believe this isn't mentioned in the coding style, though, so it might not
be required):
{{{
#if X
# include <y>
# define Z
#endif
}}}
* line 513: the parentheses are now superfluous
* line 895: missing spaces around '='
The unit tests are greatly appreciated!
--
Ticket URL: <https://dev.haiku-os.org/ticket/12710#comment:35>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
