#11518: Implement BFont::Blocks
--------------------------------+------------------------------------------
Reporter: dsizzle | Owner: axeld
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Kits/Interface | Version: R1/Development
Kit |
Resolution: | Keywords: bfont, blocks, font, unicode
Blocked By: | Blocking: 3651
Has a Patch: 1 | Platform: All
--------------------------------+------------------------------------------
Comment (by axeld):
I'm not quite sure how this can compile, since unicode_block only has a
constructor that takes two arguments, and also doesn't have the space to
store more.
The rest of the patch looks quite nice, however; you also do a great job
at not letting your code stick out.
I have a couple of coding style issues, though (which might be issues
found in the surrounding, code, too):
- Font.cpp, line 848: the if clause should fit 80 characters, and should
thus be on a single line.
- ServerFont.cpp, line 464ff, 487: single line blocks don't get {}.
- ServerFont.cpp, line 474: Should be a doxygen style comment. Sentences
start with upper case.
- ServerFont.cpp, line 486: We require boolean expressions in if's, ie.
that would be `if ((curVal & 0x80000000) != 0)`. Also, `curVal` is not a
good name.
Thanks!
--
Ticket URL: <https://dev.haiku-os.org/ticket/11518#comment:24>
Haiku <https://dev.haiku-os.org>
The Haiku operating system.
