#10954: Install and begin using Gerrit -------------------------+---------------------------- Reporter: kallisti5 | Owner: haiku-web Type: bug | Status: new Priority: blocker | Milestone: R1/alpha5 Component: Website | Version: R1/Development Resolution: | Keywords: gerrit Blocked By: | Blocking: Has a Patch: 0 | Platform: All -------------------------+---------------------------- Comment (by pulkomandy): There are several use cases for Gerrit: * Experimenting with the release branch to avoid manual cherry picking * Changing our patch submission workflow so patches go on Gerrit instead of Trac. This immediately adds the "apply patch" button everyone has been requesting, and also adds a better interface for inline code review. With further configuration, this can be paired with the build bots so each patch is ran through them, and ideally, we would also run a style checker. As a result, developers need to review a patch only for functionality and design, rather than spending time on checking that it builds and follows the coding guidelines. Patch submitter gets immediate feedback on wether his patch has guidelines violations or breaks the build. * I also think moving our after-the-fact code reviews on the commits ML to Gerrit might be a good idea, there were concerns that we don't have the manpower for systematic code review and that it would slow down development ; but I will certainly run my patches through it so I'm not the guy who breaks the build and introduces style violations anymore. This also opens the way for more patch validation, eg running our UnitTests on the patches. I hope we can get a more complete set of unit tests to make this really useful. -- Ticket URL: <https://dev.haiku-os.org/ticket/10954#comment:6> Haiku <https://dev.haiku-os.org> Haiku - the operating system.