[haiku-bugs] Re: [Haiku] #10954: Install and begin using Gerrit

  • From: "luroh" <trac@xxxxxxxxxxxx>
  • Date: Tue, 17 Jun 2014 22:09:15 -0000

#10954: Install and begin using Gerrit
   Reporter:  kallisti5  |      Owner:  haiku-web
       Type:  bug        |     Status:  new
   Priority:  blocker    |  Milestone:  R1/alpha5
  Component:  Website    |    Version:  R1/Development
 Resolution:             |   Keywords:  gerrit
 Blocked By:             |   Blocking:
Has a Patch:  0          |   Platform:  All

Comment (by luroh):

 Replying to [comment:3 kallisti5]:
 > The overall goal is to utilize gerrit to filter commits against a
 release branch.
 This sounds more like a means of reaching some goal than a goal in itself.

 > For Example:
 >   * Haiku R1A5 is branched
 >   * Developer thinks a change should go into R1A5
 >     * Developer pushes change to mainline, and the R1A5 branch
 >     * R1A5 commit is queued for peer / RC review and accepted /
 discussed / rejected
 This approach would suffer from the same problem as during the previous
 cycles, people running and testing fixes on the master branch instead of
 the release branch. Fixes should be developed on the release branch and
 merged to master where appropriate.

 > This is nice because it makes the person pushing the change, and who
 knows the code best, decide something should make it into a release.  The
 other devs and RC can then give feedback.
 How is that? It sounds more like this supposedly knowledgeable person is
 pushing the commit into master, while it gets queued up for peer review
 for the release branch.
 Granted, it would save the RM some work keeping track of '+alpha' comments
 in the commit logs. It however wouldn't solve the problem of people
 forgetting to nominate their commits for branch inclusion.

Ticket URL: <https://dev.haiku-os.org/ticket/10954#comment:4>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: