[haiku-appserver] Re: [Haiku-commits] r13174 - haiku/trunk/src/kits/interface

  • From: "Stephan Assmus" <superstippi@xxxxxx>
  • To: haiku-appserver@xxxxxxxxxxxxx
  • Date: Mon, 20 Jun 2005 11:25:27 +0200 (MEST)


> >     This means it does not reset to initial state, but use the one 
> > active 
> > before Draw() was called.

Of course. It is totally expected for me. If I set the highcolor outside
Draw(), then I expect it to be still active on the next Draw(). Usually I
configure a view in its constructor or AttachedToWindow(), and I expect it
to be like this in Draw().

> >     I don't know if that's good or bad... we have to decide.
> I would rather think it's bad, ie. let's not follow the path set by R5, 
> and see how many problems that bring us :-)

As a user of the API, I always found it rather logical, that a new state
inherits from the current state. Isn't it much more convenient as well? Why
would you want *default* params either? And I would expect quite a few
problems if we changed this behaviour.

> >     Shouldn't we go back to the state which was active before Draw() 
> > was 
> > called?
> >     Shouldn't we reset to the initial state, push a state and then 
> > enter 
> > Draw()?
> Same as above, I think we should aim for the cleanest solution, and if 
> that doesn't work out, get gradually worse until it does.

That one I agree on. If the BView is ment to be in the state as before
Draw(), then it really should be.

Best regards,

Weitersagen: GMX DSL-Flatrates mit Tempo-Garantie!
Ab 4,99 Euro/Monat: http://www.gmx.net/de/go/dsl

Other related posts: