Le 16/09/2017 à 15:19, Jacob Nevins a écrit :
Igx The Dreaming Drummer... writes:
Could anyone commit these for me in S2_6 branch, please ?
I've committed them to S2_6, and they will make it into 2.6.0-beta1.
Thank you
I've not merged them to S3_0 and master, as it looks like you were
already active on those branches.
That's right - thank you :)
I've taken the liberty of fixing a couple of format errors in Qt
strings: one we discussed before, and another that I noticed in passing.
Hope that's OK.
<https://github.com/freeciv/freeciv/commit/6edbce2a4d><https://github.com/freeciv/freeciv/commit/6edbce2a4d>
Totally - thank you very much. Strange msgfmt --statistics did not point those
out...
Also, I would like git access to be able to do the commits myself, as
I did with SVN.
Of course, you would be welcome.
Do you have a Github account?
<http://www.freeciv.org/wiki/Freeciv_source_read-write_access_for_developers_and_translators><http://www.freeciv.org/wiki/Freeciv_source_read-write_access_for_developers_and_translators>
describes the procedure (such as it is).
Just created one : igx31
I would also point out a suspicious update of a string :
#: client/options.c:3175
where 'nick' has been replaced by 'username'... whereas I first
thought it would mean "mute".
(That was my update in 29c84a1.
<https://github.com/freeciv/freeciv/commit/29c84a1#diff-eb6c29f9ed9b8cafa5d2ceda643b3087L3174><https://github.com/freeciv/freeciv/commit/29c84a1#diff-eb6c29f9ed9b8cafa5d2ceda643b3087L3174>)
I'm not sure what you mean here? I believe 'nick' and 'username' mean
the same thing, a string identifying a user. (I think 'nick' is IRC
terminology, short for 'nickname'.)
I think that's what it does, anyway; there's no 'mute' (suppress
messages or noises) functionality here.
I know about the "nickname" thing, but as it was all about pre-game sound, I
though that "%1" was used to "nick" the sound... Reading the code around update
29c84a1 gave sense to the "nick" as "username" indeed. Thank you. I'm afraid my
translation was totally out of scope in previous versions of the file...
--
________________________________
Igx, The Dreaming Drummer...(igx31@xxxxxxxxxxx<mailto:igx31@xxxxxxxxxxx>)
Freeciv French translator
