[dokuwiki] Re: [PATCH] Limiting use of readdir in the idx_indexLengths function.
- From: Andreas Gohr <andi@xxxxxxxxxxxxxx>
- To: dokuwiki@xxxxxxxxxxxxx
- Date: Mon, 22 Mar 2010 22:36:26 +0100
> It's already done in my local files :) , that's in the config plugin only
> right?
correct
> I'll try, but i'm also working on similar improvements for other functions
> in dokuwiki, like the search() in inc/search.php, should i think on a
> generic function in io.php perhaps, or a get/create function per source file
> is better ?
depends on how specific the stuff is that has to be done to create the
file's content. For the task at hand I'd think it should be some ft_*
function.
> By the way, do you prefer a unique patch for all this
> improvements or a patch per function modified like my first one?
One (or multiple) patch(es) per functionality is preferred. It might
be that I like one functionality but not another. Having multiple
patches makes cherry picking much easier.
Andi
--
splitbrain.org
--
DokuWiki mailing list - more info at
http://www.dokuwiki.org/mailinglist
Other related posts:
