[dokuwiki] Re: [PATCH] Limiting use of readdir in the idx_indexLengths function.
- From: YoBoY <yoboy.leguesh@xxxxxxxxx>
- To: dokuwiki@xxxxxxxxxxxxx
- Date: Mon, 22 Mar 2010 21:04:20 +0100
Each searches on the wiki use this function. Scanning the index directory
each time is time consuming with a constant series of disk access.
Switching a normal search to use file_exists 1 or more times, and not
readdir all the directory.
Switching a wildcard search to use a lengths.idx file containing all the
word lengths used in the wiki, file generated if a new configuration
parameter $conf[readdircache] is not false and fixed to a time in second.
1) the changes contain trailing whitespaces and tabs, please remove
the former and convert the latter to spaces
yes, sorry, trying eclipse ide and is messing with the two :] I need to
clean this.
2) please provide config metadata for the new config option
It's already done in my local files :) , that's in the config plugin
only right?
3) $conf['readdircache'] should default to 0 instead of false to avoid
problems with the config manager
Ok, not really a problem, i like the False, but 0 should be fine too
5) I would move the whole get or create the length index algorithm to
it's own function, idx_indexLenghts() is quite complex already
I'll try, but i'm also working on similar improvements for other
functions in dokuwiki, like the search() in inc/search.php, should i
think on a generic function in io.php perhaps, or a get/create function
per source file is better ? By the way, do you prefer a unique patch for
all this improvements or a patch per function modified like my first one?
Thanks
YoBoY
--
DokuWiki mailing list - more info at
http://www.dokuwiki.org/mailinglist
Other related posts:
