[codeface] Re: [PATCH 15/27] Install snatm and tm-plugin-mail from local repositories

  • From: Wolfgang Mauerer <wolfgang.mauerer@xxxxxxxxxxxxxxxxx>
  • To: <codeface@xxxxxxxxxxxxx>
  • Date: Sun, 27 Sep 2015 09:17:08 +0200



Am 27/09/2015 um 03:16 schrieb Andreas Ringlstetter:

Good morning,

This is not going to work as expected if the upstream package has been
installed previously.

The current implementation of filter.installed.packages only respects
missing, but no possibly outdated packages.

that's a good point, thanks for spotting. -- I was, however, only
considering complete re-provisionings of VMs. Rationale: We do not
(and will likely never be able to) provide updates for
incompatible database changes. Consequently, the DB will anyway
need to be re-created after a more invasive update like this one
(even if this specific one does not touch the database, the
next series will, for example). Compared to the time it takes
to re-create the DB, updating the VM is negligible.


I think we will need to extend the filter.installed.packages method by
version checking. We should do that anyway, as we should not rely on
installed package versions being compatible with Codeface.

If you can contribute this, it's highly welcome. This would give us a
chance to prolong VM lifetime a bit.

See
http://stackoverflow.com/questions/11103189/how-to-find-out-which-package-version-is-loaded-in-r
for a short list of different methods how to check the package versions.

Sidenote: If a patched package is installed, it shouldn't share the same
version number as the upstream package, or the previously mentioned
approach wont work. This is controlled by the DESCRIPTION file in the
pkg/ directory.

agreed. The current github state for snatm and tm.plugin.email is only
a band-aid; an RFCs will come in a separate thread (in short, the
tm.plugin.email patch will go upstream for sure; not sure how to handle
snatm best yet).

Best regards, Wolfgang Mauerer


Greetings,
Andreas Ringlstetter

Am 27.09.2015 um 02:28 schrieb wolfgang.mauerer@xxxxxxxxxxxxxxxxx:
From: Wolfgang Mauerer <wolfgang.mauerer@xxxxxxxxxxx>

We need to apply local changes to the packages that
are not yet merged upstream. Until these are merged,
install from inofficial locations containing the
required fixes.

Signed-off-by: Wolfgang Mauerer <wolfgang.mauerer@xxxxxxxxxxxxxxxxx>
---
packages.R | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/packages.R b/packages.R
index 2a64642..4378aee 100644
--- a/packages.R
+++ b/packages.R
@@ -23,11 +23,15 @@ if(length(p) > 0) {
}


-p <- filter.installed.packages(c("snatm", "tm-plugin-mail"))
+p <- filter.installed.packages(c("shinyGridster"))
if(length(p) > 0) {
- install.packages(p, repos="http://R-Forge.R-project.org";)
+ devtools::install_github("wolfgangmauerer/tm-plugin-mail/pkg")
}

+p <- filter.installed.packages(c("snatm"))
+if(length(p) > 0) {
+ devtools::install_github("wolfgangmauerer/snatm/pkg")
+}

p <- filter.installed.packages(c("shinyGridster"))
if(length(p) > 0) {



Other related posts:

  1. Home
  2. codeface
  3. Archive
  4. 09-2015