Good morning,
This is not going to work as expected if the upstream package has been
installed previously.
The current implementation of filter.installed.packages only respects
missing, but no possibly outdated packages.
I think we will need to extend the filter.installed.packages method by
version checking. We should do that anyway, as we should not rely on
installed package versions being compatible with Codeface.
See
http://stackoverflow.com/questions/11103189/how-to-find-out-which-package-version-is-loaded-in-r
for a short list of different methods how to check the package versions.
Sidenote: If a patched package is installed, it shouldn't share the same
version number as the upstream package, or the previously mentioned
approach wont work. This is controlled by the DESCRIPTION file in the
pkg/ directory.
Greetings,
Andreas Ringlstetter
Am 27.09.2015 um 02:28 schrieb wolfgang.mauerer@xxxxxxxxxxxxxxxxx:
From: Wolfgang Mauerer <wolfgang.mauerer@xxxxxxxxxxx>
We need to apply local changes to the packages that
are not yet merged upstream. Until these are merged,
install from inofficial locations containing the
required fixes.
Signed-off-by: Wolfgang Mauerer <wolfgang.mauerer@xxxxxxxxxxxxxxxxx>
---
packages.R | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/packages.R b/packages.R
index 2a64642..4378aee 100644
--- a/packages.R
+++ b/packages.R
@@ -23,11 +23,15 @@ if(length(p) > 0) {
}
-p <- filter.installed.packages(c("snatm", "tm-plugin-mail"))
+p <- filter.installed.packages(c("shinyGridster"))
if(length(p) > 0) {
- install.packages(p, repos="http://R-Forge.R-project.org";)
+ devtools::install_github("wolfgangmauerer/tm-plugin-mail/pkg")
}
+p <- filter.installed.packages(c("snatm"))
+if(length(p) > 0) {
+ devtools::install_github("wolfgangmauerer/snatm/pkg")
+}
p <- filter.installed.packages(c("shinyGridster"))
if(length(p) > 0) {
