[ciphershed] Re: Reviewed commit e8529e95d89d3f519a31ef7de5bd7f0d0d318e8c

  • From: Bill Cox <waywardgeek@xxxxxxxxxxxxxx>
  • To: ciphershed@xxxxxxxxxxxxx
  • Date: Wed, 02 Jul 2014 15:35:52 -0400

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 7/2/2014 11:02 AM, Rocki Hack wrote:
> IsVolumeClassFilterRegistered() is actually a problematic
> function. We might already broke backward compatibility (e.g. for
> system encryption) because of rebranding.
...
> It's used in DriveFilter.c: 
> https://github.com/CipherShed/CipherShed/blob/master/src/Driver/DriveFilter.c#L527
>
>  You can find the volume filter here: 
> https://github.com/CipherShed/CipherShed/blob/master/src/Driver/VolumeFilter.c

Excellent
> 
catch!  I'll take a look, but it looks like you are our
resident Windows API expert.  It probably makes more sense for you to
fix the code, while the rest of us try to verify it.

Bill
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTtF8YAAoJEL9an3rWhBk+8UoP/AhTj8/nNJJP43cLBnNf/CBR
GSRk3CoKE1JHJr995Z0CMkOqj6UXcn3OhvXusqXe4nELva/e8uQUZffp9JK09OGe
qqyQr80cZ+L4O6ODFCfYS8NrWDM2Bht9fdcOglNcW4gMCTBIs+VCSrKw0gLnaw6s
QMGkbFrwutjnzjZVrINw7LNVSVahssp/6mTSw2cTT4mJ0oLHu+kDOKMKzF80FWnB
XYiuGF7+UJT9Zk1PMU233Xf1GwaRr0Z2/C2W8ETrVYYRNL9fXhwFdeHB1lluV38F
4u+nGU50e2vRwTsuWMoQGBbvLoCgHoq0K0AuJU8tFurcKOXaAfTW2Pti/EitqYv4
gCP0g+6gNTb1BW2hgG8KsFrFCdGWf1h1A/7q0tMsyt7NDwoMFA29vNBXPM0zRsal
tHdT19ndCffLmgKQudNAY+kead2Unzqf+jQnnGCPOByg+2SRR28wF0jsqflPO9oG
ElQY3moxhNXx5d9MeII4dZKc6Rtg0wd0w5BswF6otzkvrg8w90vvTdmRGhGMB8X9
IJNEGc4EhWcKmZwk08y5MoYYJC1ktU0HVOrefo3XNTWnclK+fm6Ur2JEkgfHx9vx
bsj/g1HBaGLVNvTuBZ43bmHr2wJK0miJfzgYjj2w+b64UIhcr9zjliAFXTP9NAd7
uIIjlsHjoJHnp/ERycE0
=fg4o
-----END PGP SIGNATURE-----

Other related posts: