> -----Original Message----- > From: Bill Cox > Sent: Tuesday, July 01, 2014 16:12 > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > I have verified that the latest master HEAD, > e8529e95d89d3f519a31ef7de5bd7f0d0d318e8c, looks good to me. Mostly > the git-diffs are from moving all the source to the src directory. > > There is one minor issue I found. Line 3045 of src/Driver/ntdriver.c > uses the class ID from TrueCrypt. Class IDs are documented here: > > http://msdn.microsoft.com/en-us/library/ms970651.aspx > > I think we need a different, random class ID if we don't want to > collide with TrueCrpyt running on the same system. This basically is > the ID Windows uses to allow COM objects to communicate with each > other. They are all supposed to be unique. I wanted feedback on this > issue before fixing it, but I'm leaning towards creating a random-ish > ID. To show that I didn't cherry pick the random ID for some > nefarious purpose, I would use the latest hex digits from our commit > history, rather than trusting a random number generator. Would this > be OK? Well guidgen.exe gives me {5D935866-978E-4c11-9B95-9839424687A4}, but I want to have some fun with this, its been a long day. So here is the game, hang GUID: We have 8 rounds, Bill seeded the game above with his commit review. XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX E8529E95D89D3519A31EF7DE5BD7F0D0D318E8C Each time you reply (signed only please, take 2, see long day), delete one character, I went first. Seven rounds to go. -Jason -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- - - - Jason Pyeron PD Inc. http://www.pdinc.us - - Principal Consultant 10 West 24th Street #100 - - +1 (443) 269-1555 x333 Baltimore, Maryland 21218 - - - -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- This message is copyright PD Inc, subject to license 20080407P00.
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
