[bookport] Re: Minor grammatical error in BP firmware
- From: "Walt Smith" <walt@xxxxxxxxxx>
- To: <bookport@xxxxxxxxxxxxx>
- Date: Thu, 16 Mar 2006 12:06:32 -0500
Unless the code uses a message file, in which case you have to write a new
message, code the If statement, etc. As I said, I personally don't consider
it worth the effort, but if they want to fix it, fine. If it's such a common
error in so many places, there must be a good reason aside from sheer
programmer laziness that it doesn't get fixed more frequently.
----- Original Message -----
From: "Andrew Hart" <ahart@xxxxxxxxxxxxx>
To: <bookport@xxxxxxxxxxxxx>
Sent: Thursday, March 16, 2006 12:02 PM
Subject: [bookport] Re: Minor grammatical error in BP firmware
Walt,
Though it doesn't bother me whether or not the device gets single
hours and minutes correct--this is such an unbelievably common error
in many products that it is easy to ignore because we are so
accustomed to it these days. However, I would dispute that it is
difficult to do and not worthwhile. In fact fixing BP to do this
would probably be a quick five minute exercise in coding and I don't
believe I am exagerating much at all. It is likely that no parsing
is required as the time would be obtain from registers or using a low
level lib cfunction that would return the time in a c struct or by
reference in a bunch of ints of some flavour. Even if it were
returned in some packed format, the existing code already must unpack
it to chug it to the DoubleTalk for voicing, so there's no extra
work. What is required are two lines (or one if you squash it all
up) of code containing and if statement which appends an s to the
word hour if the hour value is not equal to 1. The same goes for
minutes. Trivial!
I suspect Larry could manage this while in rem sleep. *smile*
And, depending on the tightness of the code generated by the
compiler, I doubt these changes would add much more than 30 bytes to
the BP software memory footprint and possibly much less.
Cheers,
Andrew.
At 10:38 16-03-2006, you wrote:
>Agreed. You'd have to have code that parsed the hours value and then chose
>to use either "hour" or "hours" based on that value. It's not worth it.
>
>----- Original Message -----
>From: "Russ & Valerie" <valruss@xxxxxxxxxxx>
>To: <bookport@xxxxxxxxxxxxx>
>Sent: Wednesday, March 15, 2006 7:22 PM
>Subject: [bookport] Re: Minor grammatical error in BP firmware
>
>
>Gee, let's all cool down. Is it really worth the effort time and bytes?
>
>I see the same issue with many applications.
>
>I think it would be good to have it technically correct, but I can live
>with
>it.
>
>
>----- Original Message -----
>From: "Eric StevenS" <sseric57@xxxxxxxxxxx>
>To: <bookport@xxxxxxxxxxxxx>
>Sent: Wednesday, 15 March, 2006 16 23
>Subject: [bookport] Re: Minor grammatical error in BP firmware
>
>
> > If it is worth doing, isn't it worth doing right.
> >
> > Or are the rules different for different people/products.
> >
> >
> > ----- Original Message -----
> > From: "Richard Ring" <ring.richard@xxxxxxxxxxxxxxxxx>
> > To: <bookport@xxxxxxxxxxxxx>
> > Sent: Wednesday, March 15, 2006 3:23 PM
> > Subject: [bookport] Re: Minor grammatical error in BP firmware
> >
> >
> > Please!
> >
> > -----Original Message-----
> > From: bookport-bounce@xxxxxxxxxxxxx
> > [mailto:bookport-bounce@xxxxxxxxxxxxx] On Behalf Of Brian Buhrow
> > Sent: Wednesday, March 15, 2006 1:33 PM
> > To: bookport@xxxxxxxxxxxxx
> > Cc: buhrow@xxxxxxxxxxxxxxxxxxxxx
> > Subject: [bookport] Minor grammatical error in BP firmware
> >
> >
> > Hello. This bug is not serious, but worth mentioning. If
> > you're
> > listening to an audio file, and you press the 5 key to get the elapsed
> > time
> > since the beginning of the file, Bookport will say "1 hours, 5 minutes"
> > instead of "1 hour, 5 minutes". A minor nit, to be sure, but this is
> > the
> > beta tester's list, right? :)
> > -Brian
> >
> >
> >
> >
> >
> > --
> > No virus found in this incoming message.
> > Checked by AVG Free Edition.
> > Version: 7.1.385 / Virus Database: 268.2.3/281 - Release Date: 3/14/2006
> >
> >
Other related posts:
