Re: [yoshimi-user] MIDI control

  • From: Kristian Amlie <kristian@xxxxxxxxxx>
  • To: yoshimi-user@xxxxxxxxxxxxxxxxxxxxx
  • Date: Thu, 10 Apr 2014 09:37:10 +0200

On 08/04/14 22:58, Will Godfrey wrote:

If I remember correctly, the jack ring buffer is a very simple
structure, not specific to MIDI in particular. So I see no problem
lifting it out of the MIDI specific section altogether and into a more
generic section.

It is indeed very simple, far simpler than many others I've had a look at
recently.

I did think about moving it to a common point. The only one that seems
relevant
is synthengine (in misc). It already has links to both alsa and jack engines.
However is it right to just add on this functionality or should a completely
new section be created? If the latter, then I'm afraid that would be quite
beyond my current abilities :(

Unless you want to use it for something else than passing MIDI data
around (regardless of alsa/jack backend), I think a separate section is
unnecessary. It was already in a very specific code section, so even
moving it to SynthEngine makes it much more generic.

SynthEngine.cpp sounds like a logical place, though I admit I haven't
looked closely at the code.

--
Kristian



Other related posts: