[pisa-src] Re: r1558 - in trunk: Makefile.am community-operator/co_server.c community-operator/hipl.c community-operator/hipl.h community-operator/pisa_cert.c community-operator/pisa_cert.h configure.ac

  • From: René Hummen <rene.hummen@xxxxxxxxxxxxxxxxx>
  • To: pisa-src@xxxxxxxxxxxxx
  • Date: Mon, 09 Nov 2009 14:24:08 +0100


On Nov 6, 2009, at 6:06 PM, Thomas Jansen wrote:

-       /* get the default HIT from hipd, 16 is SO_HIP_DEFAULT_HIT */
-       if (hip_build_user_hdr(msg, 16, 0) != 0) {
-               free(msg);
+       /* get the default HIT from hipd */
+       if (hip_build_user_hdr(msg, SO_HIP_DEFAULT_HIT, 0) != 0) {
+               hip_msg_free(msg);
                return -1;
        }

I just noticed during the last merge of midauth2 with userspace that the message types tend to change every now and then, as developers are adding new messages with "SO_HIP_LAST + 1". This results in conflicts, when new new message types were added on both branches. Of course such old message types as SO_HIP_DEFAULT_HIT should not be affected, we should just keep the floating nature of message types in mind. Hopefully this issue will improve soon...

Ciao,
René


---
Dipl.-Inform. René Hummen, Ph.D. Student
Distributed Systems Group
RWTH Aachen University, Germany
tel: +49 241 80 20772
web: http://ds.rwth-aachen.de/members/hummen

Other related posts: