[pisa-src] Re: r1558 - in trunk: Makefile.am community-operator/co_server.c community-operator/hipl.c community-operator/hipl.h community-operator/pisa_cert.c community-operator/pisa_cert.h configure.ac
- From: Diego Biurrun <diego@xxxxxxxxxx>
- To: pisa-src@xxxxxxxxxxxxx
- Date: Sat, 07 Nov 2009 13:18:55 +0100
On Fri, Nov 06, 2009 at 06:06:48PM +0100, Thomas Jansen wrote:
>
> Log:
> Removed HIPL dependency.
>
> Once upon a time we decided to link to against HIPL code and include the
> related headers. These times are finally over, rejoice! And they lived happily
> ever after...
.. and rejoicing was heard throughout the land ..
> --- trunk/Makefile.am Fri Nov 6 15:48:32 2009 (r1557)
> +++ trunk/Makefile.am Fri Nov 6 18:06:48 2009 (r1558)
> @@ -185,27 +186,6 @@
>
> -if PISA_WITH_HIPL
> -bin_PROGRAMS += community-operator/co_server
> -community_operator_co_server_LDFLAGS += -lm
> -
> -# Ugly hacks due to dependencies on internal HIPL stuff.
> -community_operator_co_server_CPPFLAGS = -I@PISA_HIPL_SRCDIR@
> -community_operator_co_server_CPPFLAGS +=
> -I@PISA_HIPL_SRCDIR@/libinet6/include
> -community_operator_co_server_CPPFLAGS += -I@PISA_HIPL_SRCDIR@/libinet6
> -community_operator_co_server_CPPFLAGS += -I@PISA_HIPL_SRCDIR@/libhiptool
> -community_operator_co_server_CPPFLAGS += -I@PISA_HIPL_SRCDIR@/libdht
> -community_operator_co_server_CPPFLAGS += -I@PISA_HIPL_SRCDIR@/opendht
> -community_operator_co_server_CPPFLAGS += -I@PISA_HIPL_SRCDIR@/hipd
> -community_operator_co_server_CPPFLAGS += -I@PISA_HIPL_SRCDIR@/i3/i3_client
> -community_operator_co_server_CPPFLAGS +=
> -I@PISA_HIPL_SRCDIR@/pjproject/pjnath/include
> -community_operator_co_server_CPPFLAGS +=
> -I@PISA_HIPL_SRCDIR@/pjproject/pjlib/include
> -community_operator_co_server_CPPFLAGS +=
> -I@PISA_HIPL_SRCDIR@/pjproject/pjlib-util/include
> -endif
> -
> -community_operator_co_server_LDADD =
> @PISA_HIPL_SRCDIR@/libinet6/.libs/libinet6.a
> -community_operator_co_server_LDADD +=
> @PISA_HIPL_SRCDIR@/libhiptool/.libs/libhiptool.a
It's great to be rid of this mess.
Like I already said to Thomas: If you add such hacks to the build
system, worse skeletons are to be found in some closet in some remote
part of the code.
> --- trunk/configure.ac Fri Nov 6 15:48:32 2009 (r1557)
> +++ trunk/configure.ac Fri Nov 6 18:06:48 2009 (r1558)
> @@ -115,28 +108,10 @@
>
> # Set default AM_CFLAGS for the complete project.
> AC_SUBST(AM_CFLAGS, "-std=gnu99 -Wall -Wextra -Wredundant-decls
> -Wstrict-prototypes -Wdisabled-optimization -Wpointer-arith -Wundef -Winline
> -Wno-deprecated-declarations -Wmissing-prototypes -Wwrite-strings -Wcast-qual
> -Wshadow")
>
> -if test -d "$PISA_HIPL_SRCDIR"; then
> -else
> - # HIPL generates many warnings, so we cannot enable -Werror with it.
> - AC_SUBST(AM_CFLAGS, "$AM_CFLAGS -Werror")
I think we want to keep the -Werror.
Diego
Other related posts:
