Hi, as I have said, I don't have too much time, but I appreciate NVDA
community, specially add-ons, since they have a great potential to help
even in customizzed code for someone.
The code has been too large for me at this moment, and, if it works, I
don't have many thinks to say, just providing another possibilities or
cosmetic changes.
I see a lot of sentences separated by or, like: if a==2 or c== d, etc.
In this casek, perhaps a different expresion would be more readable, for
instance:
tuple=(a, b) (or, if necessary, use a list instead a tuple.
Then: if someinfo in tuple: ...
I have thought that perhaps some kind of textInfos, with positions and
move through lines and expanding properly could be used for increase of
performance, instead of lists.
If you are interested, see the commands corresponding to the review
cursor movements, or placeMarkers add-on.
Also it's possible to make reference of a class from other. I saw this
in mirc app module.
I don't have reviewed all the code, since it's too large with many or
sentences and I don't have too much time.
Thanks.
El 17/04/2016 a las 21:02, Joseph Lee escribió:
Hi Damien,
As people always say, the first ones are hard, but despite that, you're
showing potential.
Nevertheless: As a code reviewer, I specialize in overall picture and user
experience, including headers, consistency, translatable strings and such.
Thus:
1. Please try using tabs instead of spaces for indentation for consistency
with the rest of NVDA Core source code and add-ons.
2. A short header at the top of the file would be nice. This allows others
to see the status of copyrights, who wrote the add-on and what the add-on
does.
3. It appears you are using a text editor that somehow enforces line length,
which causes certain parts of source code to break. Please try using editors
such as Notepad++ and others where this doesn't occur or has a setting to
control this.
4. You don't have to use list[len(something)-1], as list[-1] is used to
retrieve the last item of a list.
Reviews from others are appreciated.
Cheers,
Joseph
-----Original Message-----
From: nvda-addons-bounce@xxxxxxxxxxxxx
[mailto:nvda-addons-bounce@xxxxxxxxxxxxx] On Behalf Of Damien
Sykes-Pendleton
Sent: Sunday, April 17, 2016 4:31 AM
To: nvda-addons@xxxxxxxxxxxxx
Subject: [nvda-addons] Re: Getting somewhere!
Hi,
OK then, here goes.
Thanks.
Kind regards,
Damien.
-----Original Message-----
From: James Scholes
Sent: Sunday, April 17, 2016 12:22 PM
To: nvda-addons@xxxxxxxxxxxxx
Subject: [nvda-addons] Re: Getting somewhere!
Damien Sykes-Pendleton wrote:
I wasn't sure whether you could or not, that's why, given the factWe don't really need to use the application in question to give you a code
that I'm guessing I'm the only person on here who uses the application
for which it's intended.
I'm also not sure whether I should send it as part of the email, or as
a download link etc.
review. Send it through as an attachment and we'll take a look.
--
James Scholes
http://twitter.com/JamesScholes
----------------------------------------------------------------
NVDA add-ons: A list to discuss add-on code enhancements and for reporting
bugs.
Community addons are available from: http://addons.nvda-project.org To send
a message to the list: nvda-addons@xxxxxxxxxxxxx To change your list
settings/unsubscribe:
//www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
----------------------------------------------------------------
NVDA add-ons: A list to discuss add-on code enhancements and for reporting bugs.
Community addons are available from: http://addons.nvda-project.org
To send a message to the list: nvda-addons@xxxxxxxxxxxxx
To change your list settings/unsubscribe:
//www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx
