[hipl-dev] Re: [Merge] lp:~hipl-core/hipl/hipv2-modularization into lp:hipl
- From: Christof Mroz <christof.mroz@xxxxxxxxxxxxxx>
- To: mp+113825@xxxxxxxxxxxxxxxxxx
- Date: Sun, 08 Jul 2012 11:01:19 -0000
Review: Abstain
I might not be able to review this fully before next month, sorry.
I did take a look at the byte order conversion however (which I commented on
before) and it looks good. One remark:
> === modified file 'libcore/builder.c'
> --- libcore/builder.c 2012-05-12 10:21:32 +0000
> +++ libcore/builder.c 2012-07-07 13:54:21 +0000
> @@ -1556,6 +1611,68 @@
> + // host to network byte order transform
> + convert_byte_order(list_content, item_count, item_size, true);
...
> + /* network to host byte order transform */
> + convert_byte_order(buffer, actual_count, item_size, false);
There are at least two ways to make such code more self-documenting, and thus
get rid of the comments:
- Introduce constants for the boolean switches, e.g.
enum cbo_flags {
CBO_HTON = true,
CBO_NTOH = false
}
- Write wrapper functions that pass true or false
--
https://code.launchpad.net/~hipl-core/hipl/hipv2-modularization/+merge/113825
Your team HIPL core team is subscribed to branch lp:hipl.
Other related posts:
