[haiku-gsoc] Re: New timer patch (again) (Was: Re: First timer.diff (from private e-mails))
- From: "Dustin Howett" <alaricx@xxxxxxxxx>
- To: haiku-gsoc@xxxxxxxxxxxxx
- Date: Wed, 2 Jul 2008 14:36:29 -0400
On Wed, Jul 2, 2008 at 6:59 AM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
> Sorry for the late reply, and thanks for the changes!
> There are still some style issues, and I can't really see why it's so
> hard to fix them, like:
>
It's not so much that they're hard to fix, it's just that they're not
second-nature to me yet and as such I can't spot them on-the-fly.
>
> But I still don't understand why you need the priority = -1 thing at
> all. AFAICS, all timers are initialized in the loop, and the timers are
> never iterated twice or partially; I would just remove it unless you
> have a good reason for this construct.
>
Not all the timers are initialized in the loop. gAPICTimer is
initialized in arch_smp.c because its init needs to be called once for
each CPU apic_init (IIRC) is running on.
Stefano and I are working out a better way to do this.
> Bye,
> Axel.
Thanks for looking over the patch and your constructive criticism.
-- Dustin
Other related posts:
