[haiku-development] Re: VOTE commit access for Augustin
- From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Thu, 24 Jul 2014 10:24:34 +0200 (CEST)
> On July 24, 2014 at 9:52 AM pulkomandy <pulkomandy@xxxxxxxxxxxxx> wrote:
> A quick review of these patches spotted a typo
> (http://cgit.haiku-os.org/haiku/commit/?id=ca38bad855ed8c1bc8b83598a2dd98f7a2909a45)
> and a suboptimal implementation
> (http://cgit.haiku-os.org/haiku/commit/?id=5f22a181ecdffd85b07ecfd5015e4b3012dbdc81).
Nice catch, and thanks for fixing those!
> Given how small the patches are, this makes me unsure wether Augustin
> is able to write more involved code. And I'm also worried that reviewers
> let those go through the patch review process.
Even small patches are appreciated, and that's also not a good basis for
granting or denying commit access IMO.
It slipped through the current review process, too, anyway, and it's not like
other people (including you and me) would always produce the greatest code.
> Most of the work Augustin did so far is on the Qt port and a work in
> progress KDElibs port, which is appreciated, but not really in line with
> what I want Haiku to be.
That's not what I'm aiming for either, but it may make use the current Haiku a
lot more convenient.
Bye,
Axel.
Other related posts:
