[haiku-development] Re: VOTE commit access for Augustin
- From: pulkomandy <pulkomandy@xxxxxxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Thu, 24 Jul 2014 10:50:05 +0200
> > Given how small the patches are, this makes me unsure wether Augustin
> > is able to write more involved code. And I'm also worried that reviewers
> > let those go through the patch review process.
>
> Even small patches are appreciated, and that's also not a good basis for
> granting or denying commit access IMO.
> It slipped through the current review process, too, anyway, and it's not like
> other people (including you and me) would always produce the greatest code.
They are appreciated, but I'd like to see more of those and make sure
Augustin has good knowledge of our APIs and coding style, which is
difficult to judge on the small patches he provided so far. I think this
is already enough to not allow commit access just now, not because the
patches are wrong, but because there are not enough of them, yet.
Of course no one always write perfect code (and I rarely do). But
looking at the second fix I did (using SetToFormat instead of a more
complex code using a mix of snprintf and BString.Prepend), I think it is
a good idea to continue to have Augustin patches reviewed, so he can
learn more about the BeAPI through the patch review process and his
other haiku-related projects.
I know Augustin has been working a lot on the Qt port and also made patches
to other software in the HaikuArchives project. Maybe we should review
the changes made there as well, as I think we can find some less trivial
ones. Augustin, do you have some code there you think could serve as a
good example of your work? I would like to evaluate:
- Your knowledge of the BeAPI, so a project using that would be nice.
- Your ability to work on bigger or non-trivial changes.
--
Adrien.
Other related posts:
