[haiku-development] Re: VOTE commit access for Augustin
- From: pulkomandy <pulkomandy@xxxxxxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Thu, 24 Jul 2014 09:52:17 +0200
On Jul 23, 2014 6:19 PM, "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx> wrote:
>
> I'd like to propose commit access for Augustin Cavalier. This is what
> he's done so far:
> http://cgit.haiku-os.org/haiku/log/?qt=author&q=waddlesplash
>
A quick review of these patches spotted a typo
(http://cgit.haiku-os.org/haiku/commit/?id=ca38bad855ed8c1bc8b83598a2dd98f7a2909a45)
and a suboptimal implementation
(http://cgit.haiku-os.org/haiku/commit/?id=5f22a181ecdffd85b07ecfd5015e4b3012dbdc81).
Given how small the patches are, this makes me unsure wether Augustin
is able to write more involved code. And I'm also worried that reviewers
let those go through the patch review process.
Most of the work Augustin did so far is on the Qt port and a work in
progress KDElibs port, which is appreciated, but not really in line with
what I want Haiku to be.
Sorry, but that means a -1 from me in the current situation. I will wait
for less trivial patches and reconsider my position then.
--
Adrien.
Other related posts:
