[haiku-development] Re: Apply Clang work from midar-github.master
- From: Adrien Destugues <pulkomandy@xxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Sat, 14 Dec 2013 23:09:34 +0100
> Not that my opinions matters much, but give the guy commit access, just
> make clang a separate branch until its stable and debugged and I'd maybe
> suggest leaving it there till after R1 to reduce conflicts.
Most of the changes are to make our C++ more standard, avoid some gccisms
and also plain wrong stuff that gcc happens to compile. They should not be
breaking anything, but should that happen, having the changes in separate
commits would be better to bissect the problem.
I don't think we should give commit access without going through the usual
process (submitting some patches and geting them reviewed without a any
problem). I'd rather avoid "special" commit access rules and look at
improving our workflow instead. And yes, I did mention gerrit which I think
is a very good tool for patch review, much better than our current
trac-based stuff or even the "pull request" system at github or bitbucket.
All we need is someone to dedicate time to setting it up and administrating
it. Olta had started looking into it but there are always more important
things to do, both on our already existing infrastructure and on Haiku
itself.
--
Adrien.
Other related posts:
