[haiku-development] Re: Apply Clang work from midar-github.master
- From: Larry Baydak <lbaydak@xxxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Tue, 17 Dec 2013 16:00:55 -0500
On 13-12-14 06:21 PM, Fredrik Holmqvist wrote:
In the bigger picture I think we need a way to keep track, and give
better support to possible contributors. Right now there are so many
hoops to jump through for potential non-GSoC contributors and quite a
bit of work for devs as well. So I think it's not really good for
anyone. I understand that full commit access needs to be restricted,
but we need better ways to get there for both the contributor and the
devs. Not sure how to solve that though. /Fredrik Holmqvist, TQH
Just an idea, but for what its worth...
Why not develop some automation tools to offload the work from the Haiku
commiters.
1) A 'Haiku Style Checker' which can be run by the patch submitter.
Complete with suggested resolutions for the style violation.
If it does not pass the Style Checker, one cannot submit the
patch. (Use some sort of minimum 'passing grade' here. Am not proposing
'lint' perfection.)
2) After Style Checking, the patch is submitted. Upon submission, a Bot
working in a standard environment will temporarily apply the patches to
their relevant modules and compile them.
3) Only after the code has been Style Checked, and proven to compile do
the commiter's
need to look at the patches and review them.
Possibly some sort of tracking system can be implemented which
allows third-party reviewers to input comments to a database, possibly
reducing the workload of the regular Haiku commiter's. And maybe keep
stats on both the patch submiters and commenters.
Yes, this 'Style Checker' is vapour-ware, as well as the tracking
system. Just my 'two cents' idea.
Other related posts:
