[haiku-development] Re: Apply Clang work from midar-github.master

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Tue, 17 Dec 2013 20:57:51 +0100

Am 17/12/2013 02:02, schrieb Matt Madia:
IMO... now that we use git, which enables a multi-commit push, it may
be better for everyone
  1) for us to commit minorly flawed patches with signoff. (whitespace,
nomenclature, general style issues as opposed to implementation flaws)
  2) followed up by the committer making the minor changes and pushing
it in one hrev
  3) following up on the source of the patch (Trac, mailing list, GCI,
GSoC, etc.) with a link to the the committer's corrections to show how
it should be done.

To me, that seems a better use of time than a committer pointing out
the minor issues with a patch, waiting for a periodic contributor to
respond, only for the cycle to possibly continue.

Not really. This way, you do point out the issues, and there is nothing wrong in doing so, but you don't force the contributor to follow our style guide. You usually learn best by doing :-)

IOW it's okay to get the first few patches in faster, but after that, it should not be done anymore: it just creates more work on the side of the developers with commit access.

It's also much easier to comment on a patch than to apply it, test it, and correct it. Especially when I can comment from everywhere without the need for a build environment.

Bye,
   Axel.


Other related posts: