[haiku-commits] Re: r40322 - haiku/trunk/src/tests/kits/net/preflet/ServicesAddOn
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sun, 30 Jan 2011 21:04:06 +0100
Alexander von Gluck <kallisti5@xxxxxxxxxxx> wrote:
> On Sun, 2011-01-30 at 12:39 -0500, Ryan Leavengood wrote:
> > Not all existing code, no matter who wrote it, is guaranteed to
> > follow
> > the coding guidelines. So it isn't really an excuse to point to
> > someone else's code which doesn't follow the guidelines.
> I know, and I knew pulling a random header is unfair. I just wanted
> to
> illustrate a point.
No, it's not unfair, it doesn't make any sense. We have a coding style
guide, and everything should follow it. Since our coding style evolved
over the past years, it doesn't make sense to look at an quite old
header for inconsistencies - the header was perfectly fine at the time.
> I think the code style document on the website
> needs cleanup and reformatting. I also know most of what Axel is
> point
> out are valid problems I need to work on.
Everything I point out are valid problems :-)
Besides that, feel free to improve the coding style guide if you can,
just don't change what is there now without checking back.
Bye,
Axel.
Other related posts:
