[haiku-commits] Re: r40322 - haiku/trunk/src/tests/kits/net/preflet/ServicesAddOn

Am 30.01.2011 21:04, schrieb Axel Dörfler:

Alexander von Gluck<kallisti5@xxxxxxxxxxx>  wrote:

On Sun, 2011-01-30 at 12:39 -0500, Ryan Leavengood wrote:

Not all existing code, no matter who wrote it, is guaranteed to
follow
the coding guidelines. So it isn't really an excuse to point to
someone else's code which doesn't follow the guidelines.

I know, and I knew pulling a random header is unfair. I just wanted
to
illustrate a point.


No, it's not unfair, it doesn't make any sense. We have a coding style
guide, and everything should follow it. Since our coding style evolved
over the past years, it doesn't make sense to look at an quite old
header for inconsistencies - the header was perfectly fine at the time.


I think the code style document on the website
needs cleanup and reformatting. I also know most of what Axel is
point
out are valid problems I need to work on.


Everything I point out are valid problems :-)
Besides that, feel free to improve the coding style guide if you can,
just don't change what is there now without checking back.
Additionally, and I think this can be seen also in your screen shot, it's a bit misleading to look at the style guide examples in a browser (but how else would you look at the page...). It is displaying at 8 spaces per tab, while the style guide specifically mentions everything in Haiku is 4 spaces per tab, and that is how the style guide examples *should* be displayed. For most code in .cpp files it's not so bad, since we just keep indenting by one tab and lining stuff up is discouraged, but in the header files, stuff is supposed to line up. 

Best regards,
-Stephan

Other related posts: