[haiku-commits] Re: haiku: hrev45143 - src/apps/terminal

  • From: pulkomandy@xxxxxxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 13 Jan 2013 22:13:24 +0100

> Well, how many ECMA compliant terminals will you find vs. xterm
> terminals? Standards are great, but sometimes it's better just to follow
> the rest.

xterm has the same behavior as what I did here. It will make the colors 0..7 
bright by using colors 8..15. this still matches the ECMA standard (which 
knows only about the 8 first colors).
Using bright with other colors does not happen in any application I know. Are 
there some examples so we can compare the results in xterm and Terminal ?

> Anyway, as Sean points out, these changes have nothing to do in the
> parser. The view should decide the look, not the parser. That one should
> just forward the chosen attributes verbatim, without making such decisions.

Well, it uses bit 3 of the 8-bit color number as a 'bright' attribute, bits 0 
to 2 as the selected color (from 0 to 7), and also uses bits 3-7 when using 
xterm extended colors. The reused bit can be moved elsewhere, and the color 
mixing done at rendering time. The result will be the same.

-- 
Adrien.

Other related posts: