[haiku-commits] Re: haiku: hrev45143 - src/apps/terminal
- From: Sean Bailey <ziusudra@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 9 Jan 2013 20:10:22 -0700
On Wed, Jan 9, 2013 at 7:31 PM, Sean Bailey <ziusudra@xxxxxxxxx> wrote:
> - case 1: /* Bold
>> */
>> - case 5:
>> - fAttr |=
>> BOLD;
>> + case 1: /* Bright
>> / Bold */
>> + fAttr |=
>> FORECOLORED(8);
>> + fAttr |=
>> FORESET;
>
>
> I do think case 1 should be bright instead of bold, but it would be best
> to handle that in TermView.cpp rather than here. Consider this:
> "\E[22m\E38;5;14mSomeText\E[5mMoreText\E0m" (those escape codes are: bold
> off, color 14, color 5, default color/style) the MoreText should be color 5
> but with this commit will be color 13.
>
Another thing is that 8 should only be added if the current color is 0-7.
For example if the current color is 84 which is a bright green (51, 255,
102) this would change it to 92 which is a not so bright purple (102, 0,
204).
Other related posts:
