[haiku-commits] Re: haiku: hrev45143 - src/apps/terminal

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 13 Jan 2013 20:26:53 +0100

On 01/10/2013 10:45 PM, pulkomandy@xxxxxxxxxxxxx wrote:

On 2013-01-10 at 03:31:05 [+0100], Sean Bailey <ziusudra@xxxxxxxxx> wrote:

I do think case 1 should be bright instead of bold, but it would be best to
handle that in TermView.cpp rather than here. Consider this:
"\E[22m\E38;5;14mSomeText\E[5mMoreText\E0m" (those escape codes are: bold
off, color 14, color 5, default color/style) the MoreText should be color 5
but with this commit will be color 13.

Well, the ECMA spec has only 8 colors. So "color 13" does not mean anything
for it and using color 13 as "bright color 5" is ok. When using the xterm
extensions, you get some unexpected results, but that's non-standard anyway.
Well, how many ECMA compliant terminals will you find vs. xterm terminals? Standards are great, but sometimes it's better just to follow the rest. Anyway, as Sean points out, these changes have nothing to do in the parser. The view should decide the look, not the parser. That one should just forward the chosen attributes verbatim, without making such decisions. 

Bye,
   Axel.

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 01-2013