[haiku-commits] Re: haiku: hrev45134 - src/kits/tracker
- From: "Humdinger" <humdingerb@xxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 07 Jan 2013 14:29:14 +0100
Hi Jérôme!
On Mon, 7 Jan 2013 13:46:57 +0100 Jérôme Duval wrote:
> There is a style issue below.
> > diff --git a/src/kits/tracker/FSUtils.cpp
> > b/src/kits/tracker/FSUtils.cpp
> > index 040b2a4..b582118 100644
> > --- a/src/kits/tracker/FSUtils.cpp
> > +++ b/src/kits/tracker/FSUtils.cpp
> > @@ -2842,9 +2842,9 @@ status_t
> > _DeleteTask(BObjectList<entry_ref>* list, bool confirm)
> > {
> > if (confirm) {
> > - bool dontMoveToTrash = TrackerSettings().
> > DontMoveFilesToTrash();
> > + bool MoveToTrash = TrackerSettings().
> > MoveFilesToTrash();
> >
> > - if (!dontMoveToTrash) {
> > + if (MoveToTrash) {
> > BAlert* alert = new BAlert("",
> >
> > B_TRANSLATE_NOCOLLECT(kDeleteConfirmationStr),
> > B_TRANSLATE("Cancel"),
> > B_TRANSLATE("Move to Trash"),
I hope you mean "MoveToTrash" that should now be "moveToTrash". Or do I
miss something else?
> BTW the settings file isn't retro compatible, i.e. the old string
> isn't taken into account. This kind of changes should be avoided.
I know, I remarked on it in the ticket [1]. Do we need a more
complicated solution? After all, Tracker will re-write its settingsfile
with the newly named option after quitting...
Regards,
Humdinger
[1] https://dev.haiku-os.org/ticket/9352
--=-=--=-=--=-=--=-=--=-=--=-=--=-=--=-=--=-=--=-
Deutsche Haiku News - Haiku Gazette
http://haiku-gazette.blogspot.com
Other related posts:
