[gtk-server] Re: config file
- From: Peter van Eerten <administrator@xxxxxxxxxxxxxx>
- To: gtk-server@xxxxxxxxxxxxx
- Date: Mon, 6 Dec 2004 12:21:01 +0100
Hi Jim,
Well, no problem about those brackets, your parser was clearly written, so I
could adjust it easily. In my announcement I forgot to mention that the config
options GTK_SERVER_COMMA and GTK_SERVER_BRACKET have dispappeared also, which is
better this way.
About those memory leaks: I ran the GTK-server with Valgrind, but one of the
rules was to ignore Glib/GTK errors, that's why I did not notice it. I'll adapt
the code immediately and upload new installers today.
Thanks,
Peter
Citeren Jim Bailey <sleepydgym@xxxxxxxxx>:
> Hi Peter,
>
> looks like the brackets disappeared, I must have
> misunderstood and made things harder for you, sorry
> about that.
>
> just to quickly point out that there is now a memory
> leak. When you call g_list_free(list); it is in an if
> block, and should be at the same level as it is
> assigned, so at the end of the block starting with
> "if (strlen(inputdata) > 0)".
>
> but slightly more leaky than that, all the strings the
> list holds are allocated and won't be automatically
> freed, it is necessary to call
> g_list_foreach( list, (GFunc)g_free, NULL );
> to clear them up.
>
> nice work though, thanks for the short turnaround, I
> can have commas and brackets again :)
>
> Regards,
>
> Jim
>--
http://www.gtk-server.org
Other related posts:
