[codeface] Re: [PATCH 3/7] Remove new line characters from commit dates
- From: Wolfgang Mauerer <wm@xxxxxxxxxxxxxxxx>
- To: codeface@xxxxxxxxxxxxx
- Date: Mon, 17 Nov 2014 21:31:35 +0100
Hi Mitchell,
Am 17/10/2014 21:10, schrieb Mitchell Joblin:
> Signed-off-by: Mitchell Joblin <mitchell.joblin.ext@xxxxxxxxxxx>
> ---
> codeface/VCS.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/codeface/VCS.py b/codeface/VCS.py
> index b123f99..cbc91e1 100644
> --- a/codeface/VCS.py
> +++ b/codeface/VCS.py
> @@ -211,7 +211,7 @@ class gitVCS (VCS):
> cmd_base = 'git --git-dir={0} log --no-merges --format=%ct
> -1'.format(self.repo).split()
> cmd = cmd_base + [rev]
> date = execute_command(cmd)
> - return(date)
> + return date.strip()
do the unstripped strings lead to problems somewhere, or is this
just a cosmetic change? The reason for the change o sunfortunately
not documented.
Thanks, Wolfgang
>
> def _prepareCommitLists(self):
> """Gets the hash values (or whatever is used to identify
>
Other related posts:
