[codeface] Re: [PATCH 3/7] Remove new line characters from commit dates
- From: Mitchell Joblin <joblin.m@xxxxxxxxx>
- To: codeface@xxxxxxxxxxxxx
- Date: Tue, 25 Nov 2014 15:19:54 +0100
On Mon, Nov 17, 2014 at 9:31 PM, Wolfgang Mauerer <wm@xxxxxxxxxxxxxxxx> wrote:
> Hi Mitchell,
>
> Am 17/10/2014 21:10, schrieb Mitchell Joblin:
>> Signed-off-by: Mitchell Joblin <mitchell.joblin.ext@xxxxxxxxxxx>
>> ---
>> codeface/VCS.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/codeface/VCS.py b/codeface/VCS.py
>> index b123f99..cbc91e1 100644
>> --- a/codeface/VCS.py
>> +++ b/codeface/VCS.py
>> @@ -211,7 +211,7 @@ class gitVCS (VCS):
>> cmd_base = 'git --git-dir={0} log --no-merges --format=%ct
>> -1'.format(self.repo).split()
>> cmd = cmd_base + [rev]
>> date = execute_command(cmd)
>> - return(date)
>> + return date.strip()
>
> do the unstripped strings lead to problems somewhere, or is this
> just a cosmetic change? The reason for the change o sunfortunately
> not documented.
Yeah I think the problem was that there was a new line character
appended to the string causing some issues. I will add to the commit
message.
--Mitchell
>
> Thanks, Wolfgang
>>
>> def _prepareCommitLists(self):
>> """Gets the hash values (or whatever is used to identify
>>
>
Other related posts:
