[codeface] Re: [PATCH 4/7] bug fix: incorrect splitting command line options
- From: Wolfgang Mauerer <wm@xxxxxxxxxxxxxxxx>
- To: codeface@xxxxxxxxxxxxx
- Date: Mon, 17 Nov 2014 21:33:00 +0100
Am 17/10/2014 21:10, schrieb Mitchell Joblin:
> - the "--since" and "--before" options were not separated
> causing only the last one to be interpreted
>
> Signed-off-by: Mitchell Joblin <mitchell.joblin.ext@xxxxxxxxxxx>
> ---
> codeface/VCS.py | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/codeface/VCS.py b/codeface/VCS.py
> index cbc91e1..741f296 100644
> --- a/codeface/VCS.py
> +++ b/codeface/VCS.py
> @@ -277,10 +277,11 @@ class gitVCS (VCS):
> if self.range_by_date:
> start_date = self._getRevDate(rev_start)
> end_date = self._getRevDate(rev_end)
> - rev_range = '--since={0} --before={1}'.format(start_date,
> end_date)
> + rev_range = ['--since=' + start_date,
> + '--before=' + end_date]
>
> else:
> - rev_range = '{0}..{1}'.format(rev_start, rev_end)
> + rev_range = ['{0}..{1}'.format(rev_start, rev_end)]
>
> # TODO: Check the effect that -M and -C (to detect copies and
> # renames) have on the output. Is there anything we need
> @@ -297,7 +298,7 @@ class gitVCS (VCS):
> cmd = 'git --git-dir={0} log -M -C'.format(self.repo).split()
> cmd.append('--no-merges')
> cmd.append(self.prettyFormat)
> - cmd.append(rev_range)
> + cmd.extend(rev_range)
>
> if dir_list is not None:
> cmd.append("--")
>
looks good, thanks. --Wolfgang
Other related posts:
