[beports] Re: [RFC] diff file for gzip 1.3.12
- From: Ingo Weinhold <ingo_weinhold@xxxxxx>
- To: beports@xxxxxxxxxxxxx
- Date: Thu, 15 May 2008 00:54:04 +0200
On 2008-05-14 at 23:08:25 [+0200], Andreas Färber <andreas.faerber@xxxxxx>
wrote:
> Am 14.05.2008 um 22:44 schrieb scott mc:
>
> > Are we submitting these types of fixes, where we put in " if defined
> > (__BEOS__) && !defined (__HAIKU__) " in place of ifdef __BEOS__ ?
>
> Ingo? I have not submitted the gnulib patch yet due to the open
> question of whether or not to drop __BEOS__ completely. If it remains
> for the time being, +1 from me.
The general sentiment on the Haiku developer list seemed to be in favor of
dropping it, though there were some voices against it. I guess I'll ask
again before reviewing all my previous ports -- in doubt we'll vote on it.
Aside from that, feel free to submit the patch to the maintainers. It won't
break when we do indeed drop __BEOS__. But you should better check whether
there are other __BEOS__ ifdef'ed sections that are needed on Haiku,
because those *will* have a different behavior when we drop the macro.
> > What about the config.guess when sending updates?
>
> As mentioned earlier, do not yet. Ingo's changes are not declared
> final and afaik not merged upstream for libtool & co either.
config.guess and config.sub are generated (copied/symlinked) by automake.
You should never edit them manually. If there's a good reason for changing
them, do it in automake and commit the changes to the automake maintainers.
If your changes are BeOS specific (i.e. not affecting Haiku), I don't
really care whether or not you submit them right now. If they affect Haiku
(your mail didn't sound like they did, though), it would be nice, if you
would wait.
The Haiku automake changes might already have made it to the maintainers
BTW. A few months ago someone (I don't have the name at hand) notified me
that he submitted config.guess changes that looked like the ones for
Haiku's gcc 4, which I believe are just what I used for automake. Will have
to check that later.
CU, Ingo
--
BePorts homepage - http://tools.assembla.com/BePorts
List archives: //www.freelists.org/archives/beports
Administrative contact: brecht@xxxxxxxxxxx
Other related posts:
