Hi, Kristian!
I'm using eclipse CDT for editing. Sorry, but I know about
identation and didn't spent time on it as only I need was the
functionality of independant outputs. If this is the only bad thing
about my patch, I'll resend it tonight with proper identation.
Thanks!
27.04.2013 09:14, Kristian Amlie пишет:
By sheer coincidence I was looking at your patch right when you sent
your email. From a code perspective I think this is a very clean, nice
patch that can be included in Yoshimi (but we need to test it, of
course). It will probably have a small impact on performance, but not by
much I think. This is just moving bytes around, and no real computation.
The one nitpick I have is that the whole patch is badly indented, which
makes the code harder to read later on. This is particularly bad near
the line "if (part[npart]->Penabled)", where it makes it look like the
if is outside the for loop, when in reality, it is inside it.
Which editor do you use? It looks like the yoshimi source code uses four
spaces per block, with no tabs, and most editors can be set up to indent
this automatically. If that is fixed I think this would be a very good
patch for Yoshimi.
