Georgy, thank you for the review.
Please take a look at updated patch. List of changes:
- update wrong comment
- rename file and functions iconv_wrap* to tnt_iconv*
- remove unnecessary include file
Понедельник, 23 июля 2018, 16:17 +03:00 от Georgy Kirichenko
<georgy@xxxxxxxxxxxxx>:
Mostly good, but see on my comments bellow
On Friday, July 20, 2018 7:50:52 PM MSK Konstantin Belyavskiy wrote:
Fixing build under FreeBSD:Wrong comment
+# - Find the readline include files and libraries
+# - Include finding of termcap or curses
+iconv_wrap_openI would be like if you renamed this using pattern tnt_<name>
+iconv_wrap_close
+iconv_wrap
exception_get_stringI would be like if you used name like tnt_iconv.c
exception_get_int
lua/errno.c
+ lua/iconv_wrap.c
lua/socket.c
lua/pickle.c
lua/fio.c
diff --git a/src/lua/iconv_wrap.h b/src/lua/iconv_wrap.hI am do not really sure we need this file
new file mode 100644
index 000000000..03aee40e4
--- /dev/null
+++ b/src/lua/iconv_wrap.h