[tarantool-patches] Re: [PATCH v4 3/4] box: introduce column_mask for ck constraint

  • From: Vladislav Shpilevoy <v.shpilevoy@xxxxxxxxxxxxx>
  • To: Kirill Shcherbatov <kshcherbatov@xxxxxxxxxxxxx>, tarantool-patches@xxxxxxxxxxxxx
  • Date: Sun, 26 May 2019 15:03:34 +0300


diff --git a/src/box/ck_constraint.c b/src/box/ck_constraint.c
index 43798be76..4756f7970 100644
--- a/src/box/ck_constraint.c
+++ b/src/box/ck_constraint.c
@@ -46,17 +46,21 @@ const char *ck_constraint_language_strs[] = {"SQL"};
  * tree traversal.
  * @param ck_constraint Check constraint object to update.
  * @param space_def Space definition to use.
+ * @param column_mask[out] The "smart" column mask of fields are
+ *                         referenced by AST.
  * @retval 0 on success.
  * @retval -1 on error.
  */
 static int
 ck_constraint_resolve_field_names(struct Expr *expr,
-                              struct space_def *space_def)
+                              struct space_def *space_def,
+                              uint64_t *column_mask)
 {
     struct Parse parser;
     sql_parser_create(&parser, sql_get(), default_flags);
     parser.parse_only = true;
-    sql_resolve_self_reference(&parser, space_def, NC_IsCheck, expr, NULL);
+    sql_resolve_self_reference(&parser, space_def, NC_IsCheck, expr, NULL,
+                               column_mask);

2. Next to last argument 'expr_list' is always NULL. Please, drop it.

I still do not see that argument dropped.

Other related posts: