[tarantool-patches] Re: [PATCH v3 03/11] Introduce IPROTO_REQUEST_STATUS command
- From: Konstantin Osipov <kostja@xxxxxxxxxxxxx>
- To: Vladimir Davydov <vdavydov.dev@xxxxxxxxx>
- Date: Thu, 19 Jul 2018 10:10:31 +0300
* Vladimir Davydov <vdavydov.dev@xxxxxxxxx> [18/07/14 23:50]:
The new command is supposed to supersede IPROTO_REQUEST_VOTE, which is
difficult to extend, because it uses the global iproto key namespace.
The new command returns a map (IPROTO_STATUS), to which we can add
various information without polluting the global namespace. Currently,
the map contains IPROTO_STATUS_IS_RO and IPROTO_STATUS_VCLOCK keys,
but soon it will be added info needed for replica rebootstrap feature.
Would it be possible to move out struct status from xrow.h and
rename to box_status and move to box.h or some other place?
Perhaps we should remove it altogether, and simply pass multiple
members to xrow_decode_status()?
Other request member combos, such as authentication or call or eval have
not leaked into xrow.h before.
Otherwise the patch is OK to push.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
Other related posts:
